Container-less Kantra: Update dep label selector to explicitly not sc…

…an open-source libraries when analyze-known-libraries is not set (#407) * Update dep label selector to explictly not scan open-source libraries when analyze-known-libraries is not set Signed-off-by: kthatipally <[email protected]> * 🐛 fix podman installation Signed-off-by: Pranav Gaikwad <[email protected]> --------- Signed-off-by: kthatipally <[email protected]> Signed-off-by: Pranav Gaikwad <[email protected]> Co-authored-by: Pranav Gaikwad <[email protected]>
konveyor · Dec 17, 2024 · 5d8b3ad · 5d8b3ad
1 parent 2fa4631
commit 5d8b3ad
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 24 deletions.
diff --git a/.github/workflows/testing.yaml b/.github/workflows/testing.yaml
@@ -23,17 +23,6 @@ jobs:
     if: github.event_name == 'push' || github.event_name == 'pull_request'
     runs-on: ubuntu-latest
     steps:
-      - name: Setup Homebrew
-        uses: Homebrew/actions/setup-homebrew@master
-
-      - name: Upgrade podman 
-        run: |
-          sudo apt-get install -y ansible
-#          export DEB=$(curl -s https://passt.top/builds/latest/x86_64/ | grep deb | awk -F '"' '{ print $4}')
-#          sudo ansible -m apt -a deb=https://passt.top/builds/latest/x86_64/${DEB} localhost
-          sudo apt-get remove podman crun
-          brew install crun podman
-
       - name: Extract pull request number from inputs or PR description
         run: |
           echo "${{ github.event.pull_request.body }}"
@@ -105,17 +94,6 @@ jobs:
     if: github.event_name != 'push' && github.event_name != 'pull_request'
     runs-on: ubuntu-latest
     steps:
-      - name: Setup Homebrew
-        uses: Homebrew/actions/setup-homebrew@master
-
-      - name: Upgrade podman 
-        run: |
-          sudo apt-get install -y ansible
-          export DEB=$(curl -s https://passt.top/builds/latest/x86_64/ | grep deb | awk -F '"' '{ print $4}')
-          sudo ansible -m apt -a deb=https://passt.top/builds/latest/x86_64/${DEB} localhost
-          sudo apt-get remove podman crun
-          brew install crun podman
-
       - uses: actions/checkout@v3
         with:
           ref: ${{ inputs.tag == 'latest' && 'main' || inputs.tag }}

diff --git a/cmd/analyze-bin.go b/cmd/analyze-bin.go
@@ -100,8 +100,8 @@ func (a *analyzeCommand) RunAnalysisContainerless(ctx context.Context) error {
 	}
 
 	var dependencyLabelSelector *labels.LabelSelector[*konveyor.Dep]
-	depLabel := fmt.Sprintf("%v=open-source", provider.DepSourceLabel)
-	if a.analyzeKnownLibraries {
+	depLabel := fmt.Sprintf("!%v=open-source", provider.DepSourceLabel)
+	if !a.analyzeKnownLibraries {
 		dependencyLabelSelector, err = labels.NewLabelSelector[*konveyor.Dep](depLabel, nil)
 		if err != nil {
 			errLog.Error(err, "failed to create label selector from expression", "selector", depLabel)