Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Container-less Kantra: Update dep label selector to explicitly not scan open-source libraries when analyze-known-libraries is not set #407

Merged
merged 2 commits into from
Dec 17, 2024

Conversation

kthatipally
Copy link
Contributor

This PR is to fix the mentions/ incidents from .m2 folder even though the --analyze-known-libraries flag is not set for java binary analysis.

@eemcmullan eemcmullan added the cherry-pick/release-0.6 This PR should be cherry-picked to release-0.6 branch label Dec 16, 2024
Copy link
Collaborator

@eemcmullan eemcmullan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix!

… when analyze-known-libraries is not set

Signed-off-by: kthatipally <99229993+kthatipally@users.noreply.github.com>
@pranavgaikwad pranavgaikwad force-pushed the kthatipally/update-dep-label branch 4 times, most recently from b03e080 to f12178b Compare December 17, 2024 18:30
Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>
@pranavgaikwad pranavgaikwad force-pushed the kthatipally/update-dep-label branch from f12178b to 0571564 Compare December 17, 2024 18:37
@pranavgaikwad
Copy link
Contributor

@kthatipally I had to add this commit to fix an issue introduced due to a recent update to gh runners. hope you don't mind.

@pranavgaikwad pranavgaikwad merged commit 5d8b3ad into konveyor:main Dec 17, 2024
3 checks passed
eemcmullan pushed a commit to eemcmullan/kantra that referenced this pull request Dec 17, 2024
…an open-source libraries when analyze-known-libraries is not set (konveyor#407)

* Update dep label selector to explictly not scan open-source libraries when analyze-known-libraries is not set

Signed-off-by: kthatipally <99229993+kthatipally@users.noreply.github.com>

* 🐛 fix podman installation

Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>

---------

Signed-off-by: kthatipally <99229993+kthatipally@users.noreply.github.com>
Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>
Co-authored-by: Pranav Gaikwad <pgaikwad@redhat.com>
eemcmullan pushed a commit to eemcmullan/kantra that referenced this pull request Dec 17, 2024
…an open-source libraries when analyze-known-libraries is not set (konveyor#407)

* Update dep label selector to explictly not scan open-source libraries when analyze-known-libraries is not set

Signed-off-by: kthatipally <99229993+kthatipally@users.noreply.github.com>

* 🐛 fix podman installation

Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>

---------

Signed-off-by: kthatipally <99229993+kthatipally@users.noreply.github.com>
Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>
Co-authored-by: Pranav Gaikwad <pgaikwad@redhat.com>
Signed-off-by: Emily McMullan <emcmulla@redhat.com>
pranavgaikwad added a commit that referenced this pull request Dec 17, 2024
…y not sc… (#409)

Container-less Kantra: Update dep label selector to explicitly not scan open-source libraries when analyze-known-libraries is not set (#407)

* Update dep label selector to explictly not scan open-source libraries when analyze-known-libraries is not set



* 🐛 fix podman installation



---------

Signed-off-by: kthatipally <99229993+kthatipally@users.noreply.github.com>
Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>
Signed-off-by: Emily McMullan <emcmulla@redhat.com>
Co-authored-by: Keerthi Thatipally <99229993+kthatipally@users.noreply.github.com>
Co-authored-by: Pranav Gaikwad <pgaikwad@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick/release-0.6 This PR should be cherry-picked to release-0.6 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants