Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MTA-1297: add overwrite option #103

Merged
merged 1 commit into from
Oct 30, 2023
Merged

MTA-1297: add overwrite option #103

merged 1 commit into from
Oct 30, 2023

Conversation

eemcmullan
Copy link
Collaborator

Closes #75

pranavgaikwad
pranavgaikwad requested changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@pranavgaikwad pranavgaikwad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we instead do this for entire output directory when it's non-empty? and perhaps, move the actual cleanup behavior behind --overwrite flag?

@eemcmullan eemcmullan changed the title MTA-1297: clear stale static report on skip report option MTA-1297: add overwrite option Oct 26, 2023
pranavgaikwad
pranavgaikwad requested changes Oct 27, 2023
View reviewed changes
Copy link
Contributor

@pranavgaikwad pranavgaikwad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

requesting minor changes

cmd/analyze.go Outdated Show resolved Hide resolved
cmd/analyze.go Outdated Show resolved Hide resolved
@pranavgaikwad
Copy link
Contributor

@eemcmullan urghh sorry you will need to resolve conflict

@eemcmullan
clear stale static report on skip report option
fbb6f74 
Signed-off-by: Emily McMullan <[email protected]>

Signed-off-by: Emily McMullan <[email protected]>
@eemcmullan eemcmullan merged commit 66e9a46 into konveyor:main Oct 30, 2023
2 checks passed
eemcmullan added a commit to eemcmullan/kantra that referenced this pull request Nov 17, 2023
@eemcmullan
clear stale static report on skip report option (konveyor#103)
7090446 
Signed-off-by: Emily McMullan <[email protected]>
@eemcmullan eemcmullan deleted the skip-output branch January 23, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pranavgaikwad pranavgaikwad pranavgaikwad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Skip-report option does not clear the output directory
2 participants
@eemcmullan @pranavgaikwad