Update README: Correct Usage of --source and --target Flags in Analyze Command #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: midays <[email protected]>
Signed-off-by: midays <[email protected]>
Signed-off-by: midays <[email protected]>
Signed-off-by: midays <[email protected]>
Signed-off-by: midays <[email protected]>
midays
force-pushed
the
update-source-and-target-explanation
branch
from
2f9cc70 to
22811df
Compare
pranavgaikwad
approved these changes
Jan 15, 2024
aufi
approved these changes
Jan 16, 2024
abrugaro
approved these changes
Jan 16, 2024
|
@midays thank you for the PR! A couple of comments: Can we keep the types listed in the README as stringArray? They are defined as such here https://github.com/konveyor/kantra/blob/main/cmd/analyze.go#L56-L57. Also, can we add the same description to the commands themselves? That way |
- Added instructions for multiple flag usage in analyzeCommand. Signed-off-by: midays <[email protected]>
eemcmullan
approved these changes
Feb 1, 2024
|
@eemcmullan Hi, I don't have write access so I cannot merge this branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.