Fix version variables evaluation in github build #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using github variables to provide version and commit sha variables for build. Follow-up to konveyor#154 Signed-off-by: Marek Aufart <[email protected]>
|
@eemcmullan @djzager Sorry for complications, missed not evaluating variables in github build process. |
djzager
approved these changes
Feb 16, 2024
|
Works now, thanks 👍 |
aufi
added
the
cherry-pick/release-0.3
aufi
added a commit
to aufi/kantra
that referenced
this pull request
Feb 21, 2024
Fix version variables evaluation in build Using github variables to provide version and commit sha variables for build. Follow-up to konveyor#154 Signed-off-by: Marek Aufart <[email protected]>
Merged
aufi
added a commit
that referenced
this pull request
Feb 21, 2024
* Add version (#154) * Add version command Adding tool version to CLI that should return version number and commit hash. Usage: `kantra version`. Fixes: https://issues.redhat.com/browse/MTA-2201 Signed-off-by: Marek Aufart <[email protected]> * Update build flags Signed-off-by: Marek Aufart <[email protected]> * Update build scripts Signed-off-by: Marek Aufart <[email protected]> * Try fix buildah cmd Signed-off-by: Marek Aufart <[email protected]> * Set buildcommit before Signed-off-by: Marek Aufart <[email protected]> * Update cmd/version.go Co-authored-by: David Zager <[email protected]> Signed-off-by: Marek Aufart <[email protected]> --------- Signed-off-by: Marek Aufart <[email protected]> Signed-off-by: Marek Aufart <[email protected]> Co-authored-by: David Zager <[email protected]> * Fix version variables evaluation in github build (#156) Fix version variables evaluation in build Using github variables to provide version and commit sha variables for build. Follow-up to #154 Signed-off-by: Marek Aufart <[email protected]> --------- Signed-off-by: Marek Aufart <[email protected]> Signed-off-by: Marek Aufart <[email protected]> Co-authored-by: David Zager <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using github variables to provide version and commit sha variables for build.
Follow-up to #154