Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary entrypoint.sh +x permission, fix Windows build #167

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

dagood
Copy link
Contributor

@dagood dagood commented Feb 29, 2024

I've made some changes to fix a couple issues I ran into when building the Dockerfile on Windows, with what I'd consider a pretty typical dev configuration:

  • Windows filesystems don't preserve permissions, so re-apply script execute permission in the Dockerfile.
  • Git autocrlf is typically enabled on Windows, so add a .gitattributes to make sure scripts like entrypoint.sh are cloned with LF.

Also, I removed +x permission from the copy of entrypoint.sh in the repository. It doesn't seem like this script is useful to run on a dev machine, only looks to be useful inside the container, and now that the execute permission is applied by the Dockerfile, it's not necessary to mark it as executable in the Git repository.

Copy link
Contributor

@pranavgaikwad pranavgaikwad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dagood Thank you for taking the time to fix this!

@eemcmullan eemcmullan merged commit a24e193 into konveyor:main Mar 4, 2024
2 checks passed
@dagood dagood deleted the dev/dagood/win branch March 4, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants