Fix dependency test: update deps-output.yaml test output file. #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kthatipally thank you for the fix! Can you please sign-off your commit? |
pranavgaikwad
approved these changes
Apr 11, 2024
Signed-off-by: Davis Goodin <[email protected]> Signed-off-by: kthatipally <[email protected]>
…structure Signed-off-by: kthatipally <[email protected]>
|
@kthatipally you will need to sign all the previous commits |
kthatipally
force-pushed
the
update-dependencies-test-output-file-to-fix-GHA
branch
from
75799b6 to
72c45f7
Compare
…ate-dependencies-test-output-file-to-fix-GHA
|
@kthatipally just fyi, test failure doesn't look like its related to your change, I am looking into it |
|
@kthatipally Ok so I just spoke with @eemcmullan we are going to merge your PR right now and address this failure in a follow up right away. Thank you! |
pranavgaikwad
pushed a commit
to pranavgaikwad/kantra
that referenced
this pull request
Apr 16, 2024
…yor#191) * Fix minor README.md issues (konveyor#188) Signed-off-by: Davis Goodin <[email protected]> Signed-off-by: kthatipally <[email protected]> * Fix dependency test: update deps-output.yaml to include the new yaml structure Signed-off-by: kthatipally <[email protected]> --------- Signed-off-by: Davis Goodin <[email protected]> Signed-off-by: kthatipally <[email protected]> Co-authored-by: Davis Goodin <[email protected]>
pranavgaikwad
pushed a commit
to pranavgaikwad/kantra
that referenced
this pull request
Apr 16, 2024
…yor#191) Signed-off-by: kthatipally <[email protected]>
pranavgaikwad
pushed a commit
to pranavgaikwad/kantra
that referenced
this pull request
Apr 16, 2024
…yor#191) Signed-off-by: Keerthi Thatipally <[email protected]>
pranavgaikwad
added a commit
that referenced
this pull request
Apr 16, 2024
* 🐛 Update deps Signed-off-by: Pranav Gaikwad <[email protected]> * 👻 use correct branch in workflow Signed-off-by: Pranav Gaikwad <[email protected]> * Fix dependency test: update deps-output.yaml test output file. (#191) Signed-off-by: Keerthi Thatipally <[email protected]> --------- Signed-off-by: Pranav Gaikwad <[email protected]> Signed-off-by: Keerthi Thatipally <[email protected]> Co-authored-by: Keerthi Thatipally <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issues with the dependency test in the GitHub Actions workflow by updating the deps-output.yaml file. The changes ensure that the generated output file aligns correctly with the test file for accurate comparison.
This new structure of YAML is introduced in the dependent PR of analyzer-LSP: konveyor/analyzer-lsp#566