👻 Add Architecture support labels #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
tests are failing because centos stream is eol and they've apparently already pulled the repos. I will look to see if I can find an alternative. |
djzager
approved these changes
Jun 4, 2024
shawn-hurley
approved these changes
Jun 4, 2024
|
@shawn-hurley Good point. I'm not sure what we want to do for downstream in the immediate future. Downstream we just might want to be aware so this can be patched out. @fbladilo @rayfordj does that seem reasonable. |
Signed-off-by: Jason Montleon <[email protected]>
jmontleon
force-pushed
the
add-arch-labels
branch
from
f900fa9 to
9583def
Compare
kaovilai
approved these changes
Jun 4, 2024
rayfordj
requested changes
Jun 4, 2024
rayfordj
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have admittedly not tested extensively, but we can install and the UI comes up. Dependencies are also far less problematic on arm64 than ppc64le and s390x. However, the operator does not show up on arm64 clusters, I think because we are missing these labels.