Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve publishing #854

Closed
wants to merge 5 commits into from
Closed

Improve publishing #854

wants to merge 5 commits into from

Conversation

DRSchlaubi
Copy link
Member

This PR aims to prepare publishing for K/N and other advantages:

  • We can now automatically publish to maven central even in a KMP setup where artifacts come from different CI runs
  • We have the same ci configuration for all modules (since the plugin supports all sources)
  • We no longer have to register artifacts on our own

@DRSchlaubi
Copy link
Member Author

I think the reson it failed is because the key is wrong, see https://vanniktech.github.io/gradle-maven-publish-plugin/central/#in-memory-gpg-key

@lukellmann
Copy link
Member

the secret holds the plain ascii-armored key but base64 encoded

@DRSchlaubi
Copy link
Member Author

the secret holds the plain ascii-armored key but base64 encoded

Yeah I think that's different to what is expected here, it wants the base64 of the key, as in the parts between the ----BEGIN--- ---END--- parts

@DRSchlaubi
Copy link
Member Author

This would allow us to revert b460846

@DRSchlaubi
Copy link
Member Author

Superseded by #855

@DRSchlaubi DRSchlaubi closed this Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DRSchlaubi @lukellmann