Skip to content
This repository has been archived by the owner on May 17, 2023. It is now read-only.

Tweaks to "Targeting iOS & Android" #49

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

jeremy-w
Copy link

@jeremy-w jeremy-w commented Nov 1, 2019

  • Fixes strays \ that breaks the emitted xcode-frameworks/gradlew shell script.
  • Fixes disagreement in task name that would break Run Script Phase script if copy-pasted.
  • Provides useful error feedback on build failure due to missing gradlew-wrapper.
  • Explain more of the Gradle magic (this is going to be especially mysterious to iOS devs)
  • Run Shellcheck over the shell scripts and fix the errors.

Fixes shellcheck error
SC2068: Double quote array expansions to avoid re-splitting elements.
https://www.shellcheck.net/wiki/SC2068
Fix shellcheck warning
SC2164: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.
https://www.shellcheck.net/wiki/SC2164
The configuration is ready from the environment, not the property
that was declared here.
…rameworks wrapper

Since this is probably going to be copy-pasted into a lot of KMP
projects, let's try to smoothe that rough edge.
Let's show off that pretty Kotlin syntax. :)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant