Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adapt to changes in AndroidAsync performed to fix issue 461 #516

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mkoslacz
Copy link

I performed changes to adapt this library to work on top of AndroidAsync modified by me in commit koush/AndroidAsync@98a9d50.
It's rather quick fix, using not the best patterns, to get the stuff done, but it works flawlessly. Probably you will want to adjust it to meet your standards.
I used FileCache named storeCache in Ion to resolve method calls that were static, and I changed Ion reference to static in IonBitmapRequestBuilder, assuming that Ion is anywany called in static way, to prevent changing other methods to non-static.

I performed changes to adapt this library to work on top of AndroidAsync modified by me in commit koush/AndroidAsync@98a9d50.
It's rather quick fix, using not the best patterns, to get the stuff done, but it works flawlessly. Probably you will want to adjust it to meet your standards.
I used FileCache named storeCache in Ion to resolve method calls that were static, and I changed Ion reference to static in IonBitmapRequestBuilder, assuming that Ion is anywany called in static way, to prevent changing other methods to non-static.
@koush
Copy link
Owner

koush commented Mar 16, 2015

Ion is not always called in a static way. There may be different ion instances with different configurations, middleware, etc.

@koush
Copy link
Owner

koush commented Mar 16, 2015

I think you want to use getResposneCacheMiddleware().getCache() instead of the store cache.

The store cache is an experimental/undocumented thing to do disk i/o

@mkoslacz
Copy link
Author

I'll take a look later. If it's not always called in a static way, static methods in IonBitmapRequestBuilder will probably need to be changed to non-static, which can cause need for further changes. Although, in my simple use case it works good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants