-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Update] Support SVD method to calculate M^{-1/p}
#103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #103 +/- ##
=======================================
Coverage 99.70% 99.71%
=======================================
Files 39 39
Lines 3034 3125 +91
=======================================
+ Hits 3025 3116 +91
Misses 9 9 ☔ View full report in Codecov by Sentry. |
kozistr
changed the title
[Update] Use SVD to calculate
[Update] Support SVD method to calculate Feb 5, 2023
M^{-1/p}
instead of Schur-Newton
methodM^{-1/p}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem (Why?)
Theoretically,
Schur-Newton
method is faster thanSVD
method to calculateM^{-1/p}
. However, the inefficiency of the loop and others, in some cases, SVD is much faster than that. So, supports SVD method too. (related to #100)Solution (What/How?)
SVD
batch SVD
when the shapes of the pre-conditioners are all same. (maybe later, RaggedTensor could be used here.)ScalableShampoo
. (actually, not scalable though)Benchmark
tested on i7700K + GTX 1060 6GB.
backbone:
resmlp_12_distilled_224
, bs: 16x4.325 faster (A -> B)
backbone:
mixer_s32_224
, bs: 8x5.408 slower (A -> B)
backbone:
mixer_b16_224
, bs: 2x3.292 slower (A -> B)
code
Other changes (bug fixes, small refactors)
nope
Notes
nope