Merge develop 2024-07-18 #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lots of fixes, also requires Websock Adapter update due to internal module changes in Bandit 1.4.0.
Update Bandit to 1.5.2 See merge request pleroma/pleroma!4133
Add missing foreign key indexes See merge request pleroma/pleroma!4134
Fix Logger.warn deprecation error on OTP25 See merge request pleroma/pleroma!4135
lib/pleroma/uploaders/ipfs.ex:43:no_return
Function put_file/1 has no local return.
________________________________________________________________________________
lib/pleroma/uploaders/ipfs.ex:49:call
The function call will not succeed.
Pleroma.HTTP.post(
binary(),
_mp :: %Tesla.Multipart{
:boundary => binary(),
:content_type_params => [binary()],
:parts => [
%Tesla.Multipart.Part{
:body => binary(),
:dispositions => [any()],
:headers => [any()]
},
...
]
},
[],
[{:params, [{:"cid-version", <<49>>}]}]
)
will never return since the success typing is:
(binary(), binary(), [{binary(), binary()}], Keyword.t()) ::
{:error, _}
| {:ok,
%Tesla.Env{
:__client__ => %Tesla.Client{
:adapter => nil | {_, _} | {_, _, _},
:fun => _,
:post => [any()],
:pre => [any()]
},
:__module__ => atom(),
:body => _,
:headers => [{_, _}],
:method => :delete | :get | :head | :options | :patch | :post | :put | :trace,
:opts => [{_, _}],
:query => [{_, _}],
:status => nil | integer(),
:url => binary()
}}
and the contract is
(Pleroma.HTTP.Request.url(), String.t(), Pleroma.HTTP.Request.headers(), :elixir.keyword()) ::
{:ok, Tesla.Env.t()} | {:error, any()}
Use proper workers for fetching pins instead of an ad-hoc task Closes #3276 See merge request pleroma/pleroma!4136
IPFS uploader: dialyzer fixes See merge request pleroma/pleroma!4129
Allow Cowboy to stream the response instead of chunk it See merge request pleroma/pleroma!4138
Also add a test to validate the correct error when disabled
RichMedia: Respect configuration on status previews See merge request pleroma/pleroma!4130
Spex: Add missing notification types to the api spec See merge request pleroma/pleroma!4141
Minor cleanup commits See merge request pleroma/pleroma!4142
Bump deps See merge request pleroma/pleroma!4140
Also update other places where we use the term "send" instead of "stream". This should make it clearer that we are streaming these over websockets / web push and not sending an activity.
LDAP Authenticator: Improve error reporting. See merge request pleroma/pleroma!4171
Move poison dependency See merge request pleroma/pleroma!4156
Remove the unused ingestion queue See merge request pleroma/pleroma!4173
Discard Remote Fetcher jobs which errored due to an MRF rejection See merge request pleroma/pleroma!4174
:discard will be removed in Oban 3.0. It was only meant for internal use.
Oban: change :discard return values to :cancel See merge request pleroma/pleroma!4175
…se it These deletion tasks are slow, but the other background jobs are not. This will allow us to have a lower timeout on the normal background jobs.
Oban improvements See merge request pleroma/pleroma!4176
…erroneous MRF policies from ConfigDB
Added a Mix task "pleroma.config fix_mrf_policies" See merge request pleroma/pleroma!4177
Add Oban Live Dashboard See merge request pleroma/pleroma!4180
Oban should not retry jobs that are likely to fail again
Rework some Rich Media functionality for better error handling See merge request pleroma/pleroma!4182
Add docs for fix_mrf_policies See merge request pleroma/pleroma!4184
Dialyzer fix for RemoteFetcherWorker See merge request pleroma/pleroma!4183
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.