Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various changes #130

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Various changes #130

wants to merge 2 commits into from

Conversation

carasmo
Copy link

@carasmo carasmo commented Jun 17, 2017

  • Valid html when used more than once on a page
  • made JS friendly variable
  • Changed all screenread classes to screen-reader-text used in all Genesis themes
  • Removed #button on submit forms and added class button
  • removed inline css for screenread since the class is now screen-reader-text

carasmo added 2 commits June 16, 2017 18:23
@carasmo
Removed inline screen reader css
8649009 
In the ``BJGK_Genesis_eNews_Extended`` class, the label class was changed to screen-reader-text that comes with all Genesis child themes. Plus it's the class WordPress introduced in 2009 https://www.google.com/search?q=wordpress+screen-reader-text&ie=utf-8&oe=utf-8
@carasmo
Various
751d782 
- Valid html when used more than once on a page
   -- made JS friendly variable
- Changed all ``screenread`` classes to ``screen-reader-text`` used in all Genesis themes
- Removed #button on submit forms and added class ``button``
@carasmo
Copy link
Author

carasmo commented Jun 17, 2017

I tested this out, and it works fine with MailChimp. The code is valid html when I use this in a widget twice on the page. The only time it is odd and this is something I would mark as "not fixing" is using inside a widget created with a page builder, it doesn't error and works, but the instance is #subbox1_enews_ext_REPLACE_TO_ID (for example) instead of #subbox1_enews_ext_4 (the number changes each instance). The way around that, which I will write up a post for, is to use the shortcode any widget plugin, create the instance in the widgets panel, and use a shortcode inside the page builder. Very easy work around.

Repository owner deleted a comment from carasmo Jun 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@carasmo