Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow show/hide closed positions #65

Merged
merged 2 commits into from
Jul 22, 2024

Conversation

krazkidd
Copy link
Owner

This adds a menu item to show or hide closed positions.

@krazkidd krazkidd linked an issue Jul 22, 2024 that may be closed by this pull request
@krazkidd krazkidd self-assigned this Jul 22, 2024
@krazkidd krazkidd merged commit ebca9e1 into main Jul 22, 2024
1 check failed
Copy link

Cpp-Linter Report ⚠️

Some files did not pass the configured checks!

clang-format reports: 6 file(s) not formatted
  • include/config/Config.hpp
  • include/ui/MainFrame.hpp
  • include/ui/PortfolioPanel.hpp
  • src/config/Config.cpp
  • src/ui/MainFrame.cpp
  • src/ui/PortfolioPanel.cpp
clang-tidy reports: 16 concern(s)
  • include/config/Config.hpp:8:10: error: [clang-diagnostic-error]

    'oatpp/core/Types.hpp' file not found

    #include "oatpp/core/Types.hpp"
             ^
  • include/config/Config.hpp:22:13: warning: [modernize-use-trailing-return-type]

    use a trailing return type for this function

                DTO_INIT(UserConfig, DTO)
                ^
  • include/config/Config.hpp:25:13: warning: [modernize-use-trailing-return-type]

    use a trailing return type for this function

                DTO_FIELD(String, KalshiApiUrl);
                ^
  • include/config/Config.hpp:26:13: warning: [modernize-use-trailing-return-type]

    use a trailing return type for this function

                DTO_FIELD(String, SslTrustStoreDir);
                ^
  • include/config/Config.hpp:27:13: warning: [modernize-use-trailing-return-type]

    use a trailing return type for this function

                DTO_FIELD(String, Email);
                ^
  • include/config/Config.hpp:28:13: warning: [modernize-use-trailing-return-type]

    use a trailing return type for this function

                DTO_FIELD(Boolean, ShowClosedPositions);
                ^
  • include/config/Config.hpp:41:21: warning: [modernize-use-trailing-return-type]

    use a trailing return type for this function

            std::string GetKalshiApiUrl() const;
            ~~~~~~~~~~~ ^
            auto                                -> std::string
  • include/config/Config.hpp:43:21: warning: [modernize-use-trailing-return-type]

    use a trailing return type for this function

            std::string GetSslTrustStoreDir() const;
            ~~~~~~~~~~~ ^
            auto                                    -> std::string
  • include/config/Config.hpp:45:21: warning: [modernize-use-trailing-return-type]

    use a trailing return type for this function

            std::string GetEmail() const;
            ~~~~~~~~~~~ ^
            auto                         -> std::string
  • include/config/Config.hpp:47:14: warning: [modernize-use-trailing-return-type]

    use a trailing return type for this function

            bool GetShowClosedPositions() const;
            ~~~~ ^
            auto                                -> bool
  • include/config/Config.hpp:64:44: warning: [modernize-use-trailing-return-type]

    use a trailing return type for this function

            static std::shared_ptr<UserConfig> MakeDefaultConfig();
                   ~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^
                   auto                                            -> std::shared_ptr<UserConfig>
  • include/ui/MainFrame.hpp:4:10: error: [clang-diagnostic-error]

    'wx/wx.h' file not found

    #include <wx/wx.h>
             ^
  • include/ui/PortfolioPanel.hpp:4:10: error: [clang-diagnostic-error]

    'wx/wx.h' file not found

    #include <wx/wx.h>
             ^
  • src/config/Config.cpp:4:10: error: [clang-diagnostic-error]

    'fmt/core.h' file not found

    #include <fmt/core.h>
             ^
  • src/ui/MainFrame.cpp:3:10: error: [clang-diagnostic-error]

    'wx/string.h' file not found

    #include <wx/string.h>
             ^
  • src/ui/PortfolioPanel.cpp:1:10: error: [clang-diagnostic-error]

    'wx/wx.h' file not found

    #include <wx/wx.h>
             ^

Have any feedback or feature suggestions? Share it here.

@krazkidd krazkidd deleted the 57-provide-option-to-showhide-closed-positions branch July 22, 2024 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide option to show/hide closed positions
1 participant