Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing incompatibilities caused by Rails 6 #30

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alecslupu
Copy link

@alecslupu alecslupu commented May 30, 2020

Addresses issue reported in #29

@alecslupu alecslupu changed the title Fixing #29 Fixing incompatibilities caused by Rails 6 May 30, 2020
@fxn
Copy link

fxn commented May 31, 2020

Given what has been found as being the root cause of this (details), I wonder if Wisper could black list ActiveRecord::SchemaMigration as a known AR model users are not really interested in anyway.

@alecslupu
Copy link
Author

@fxn, In theory Wisper could filter out the SchemaMigration, however, I think the real issue resides in the fact that ActiveRecord callbacks are invoked when SchemaMigration changes are performed.
Maybe the hooks should not be called for ShemaMigration?

@fxn
Copy link

fxn commented Jun 1, 2020

From the point of view of Active Record, ActiveRecord::SchemaMigration is a class mapped to a database table. The ORM is using itself. In that sense, it is not special. Active Record has no concept of internal vs "application" models. In particular, the model lifecycle is generic.

On the other hand, that class might be considered to be special for Wisper. I mean, are users enabling Wisper::ActiveRecord.extend_all interested in all AR models for real? Or are they interested in application models only really? (I don't have an opinion, Wisper authors are the best ones to judge.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants