Slo via http (#459)

* Fix typo * Enable loading SLO profile via URL (#438)
krkn-chaos · Aug 10, 2023 · 491dc17 · 491dc17
1 parent b2b5002
commit 491dc17
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 3 deletions.
diff --git a/config/config.yaml b/config/config.yaml
@@ -59,7 +59,7 @@ performance_monitoring:
     prometheus_bearer_token:                              # The bearer token is automatically obtained in case of OpenShift, please set it when the distribution is Kubernetes. This is needed to authenticate with prometheus.
     uuid:                                                 # uuid for the run is generated by default if not set
     enable_alerts: False                                  # Runs the queries specified in the alert profile and displays the info or exits 1 when severity=error
-    alert_profile: config/alerts                          # Path to alert profile with the prometheus queries
+    alert_profile: config/alerts                          # Path or URL to alert profile with the prometheus queries
     check_critical_alerts: False                          # When enabled will check prometheus for critical alerts firing post chaos
 tunings:
     wait_duration: 60                                      # Duration to wait between each chaos scenario

diff --git a/docs/SLOs_validation.md b/docs/SLOs_validation.md
@@ -23,7 +23,7 @@ performance_monitoring:
 ```
 
 #### Alert profile
-A couple of [alert profiles](https://github.com/redhat-chaos/krkn/tree/main/config) [alerts](https://github.com/redhat-chaos/krkn/blob/main/config/alerts) are shipped by default and can be tweaked to add more queries to alert on. The following are a few alerts examples:
+A couple of [alert profiles](https://github.com/redhat-chaos/krkn/tree/main/config) [alerts](https://github.com/redhat-chaos/krkn/blob/main/config/alerts) are shipped by default and can be tweaked to add more queries to alert on. User can provide a URL or path to the file in the [config](https://github.com/redhat-chaos/krkn/blob/main/config/config.yaml). The following are a few alerts examples:
 
 ```
 - expr: avg_over_time(histogram_quantile(0.99, rate(etcd_disk_wal_fsync_duration_seconds_bucket[2m]))[5m:]) > 0.01

diff --git a/kraken/kube_burner/client.py b/kraken/kube_burner/client.py
@@ -3,7 +3,10 @@
 import urllib.request
 import shutil
 import sys
+import requests
+import tempfile
 import kraken.prometheus.client as prometheus
+from urllib.parse import urlparse
 
 
 def setup(url):
@@ -72,14 +75,22 @@ def alerts(distribution, prometheus_url, prometheus_bearer_token, start_time, en
     Scrapes metrics defined in the profile from Prometheus and alerts based on the severity defined
     """
 
+    is_url = urlparse(alert_profile)
+    if is_url.scheme and is_url.netloc:
+        response = requests.get(alert_profile)
+        temp_alerts = tempfile.NamedTemporaryFile()
+        temp_alerts.write(response.content)
+        temp_alerts.flush()
+        alert_profile = temp_alerts.name
+
     if not prometheus_url:
         if distribution == "openshift":
             logging.info("Looks like prometheus_url is not defined, trying to use the default instance on the cluster")
             prometheus_url, prometheus_bearer_token = prometheus.instance(
                 distribution, prometheus_url, prometheus_bearer_token
             )
         else:
-            logging.error("Looks like proemtheus url is not defined, exiting")
+            logging.error("Looks like prometheus url is not defined, exiting")
             sys.exit(1)
     command = (
         "./kube-burner check-alerts "