Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not fail GCP auth when GOOGLE_APPLICATION_CREDENTIALS is not found #707

Closed
wants to merge 2 commits into from

Conversation

pablomh
Copy link
Contributor

@pablomh pablomh commented Oct 4, 2024

Auth could have been set up using the Google Cloud CLI:

  • gcloud init
  • gcloud auth application-default login

Auth could have been set up using the Google Cloud CLI:

- `gcloud init`
- `gcloud auth application-default login`

Signed-off-by: Pablo Méndez Hernández <[email protected]>
Signed-off-by: Pablo Méndez Hernández <[email protected]>
@paigerube14
Copy link
Collaborator

Got this error when not setting the google application credentials.

Also would be good to add this to the docs as an alternative way to configure the cloud for this scenario

2024-10-07 13:54:51,605 [INFO] Starting node_stop_start_scenario injection
2024-10-07 13:54:51,605 [INFO] stop scenario
2024-10-07 13:54:51,605 [INFO] Starting node_stop_scenario injection
2024-10-07 13:54:51,606 [ERROR] Failed to stop node instance. Encountered following exception: 'GCP' object has no attribute 'project'. Test Failed

@chaitanyaenr
Copy link
Collaborator

Got this error when not setting the google application credentials.

cc: @pablomh

@pablomh pablomh marked this pull request as draft October 9, 2024 18:52
@pablomh
Copy link
Contributor Author

pablomh commented Oct 9, 2024

I've changed the status to DRAFT while I figure out how to avoid @paigerube14 problem. The reason I didn't spot it is because I've been testing this code using the google.auth Python API which sets project using:

credentials, project = google.auth.default()

@pablomh
Copy link
Contributor Author

pablomh commented Oct 23, 2024

Will close in favor of #723.

@pablomh pablomh closed this Oct 23, 2024
@pablomh pablomh deleted the patch-1 branch October 23, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants