Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for user-provided default network ACL #731

Merged
merged 3 commits into from
Nov 6, 2024
Merged

Add support for user-provided default network ACL #731

merged 3 commits into from
Nov 6, 2024

Conversation

TheHenrick
Copy link
Contributor

No description provided.

@TheHenrick TheHenrick force-pushed the feature/user-provided-default-nacl branch from fc57f54 to ffb92d5 Compare November 5, 2024 01:27
@paigerube14
Copy link
Collaborator

paigerube14 commented Nov 5, 2024 •
edited
Loading

This change covers the issue defined here: #730

Thanks for the contribution @TheHenrick, small nit on the comment but looks good to me otherwise!

chaitanyaenr
chaitanyaenr reviewed Nov 5, 2024
View reviewed changes
Copy link
Collaborator

@chaitanyaenr chaitanyaenr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @TheHenrick! Minor nit and PR is good for merge once that's fixed.

@TheHenrick TheHenrick force-pushed the feature/user-provided-default-nacl branch from f45e72d to 8b1e567 Compare November 6, 2024 03:23
chaitanyaenr
chaitanyaenr reviewed Nov 6, 2024
View reviewed changes
Copy link
Collaborator

@chaitanyaenr chaitanyaenr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TheHenrick can we get add default_acl_id parameter to the docs when you get time please: https://github.com/krkn-chaos/krkn/blob/main/docs/zone_outage.md and https://github.com/krkn-chaos/krkn/blob/main/scenarios/openshift/zone_outage.yaml.

@TheHenrick
Copy link
Contributor Author

@TheHenrick can we get add default_acl_id parameter to the docs when you get time please: https://github.com/krkn-chaos/krkn/blob/main/docs/zone_outage.md and https://github.com/krkn-chaos/krkn/blob/main/scenarios/openshift/zone_outage.yaml.

Updated the docs you mentioned

chaitanyaenr
chaitanyaenr approved these changes Nov 6, 2024
View reviewed changes
Copy link
Collaborator

@chaitanyaenr chaitanyaenr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@chaitanyaenr chaitanyaenr merged commit 949f1f0 into krkn-chaos:main Nov 6, 2024
5 of 7 checks passed
@TheHenrick TheHenrick deleted the feature/user-provided-default-nacl branch November 6, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaitanyaenr chaitanyaenr chaitanyaenr approved these changes

@paigerube14 paigerube14 Awaiting requested review from paigerube14

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TheHenrick @paigerube14 @chaitanyaenr