feat(batcher): send batcher transaction right before KromaMPTTime #393

0xbenyun · 2024-11-18T06:54:40Z

Description

To create the block at the point where a geth reaches KromaMPTTime, the migration must be completed up to the block immediately before the KromaMPTTime block. Since migrations are performed based on the SafeBlock, the batcher needs to be modified to immediately generate and send a batcher transaction covering all blocks up to the block just before KromaMPTTime when it encounters this block.

This PR is related to kroma-network/go-ethereum #121.

coderabbitai · 2024-11-18T06:54:48Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (2)

dev
main

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

0xbenyun · 2024-11-22T07:10:24Z

I have read the rules in .gitmessage and tried various settings for PR titles and commit messages, but the semantic PR check still fails.

kangsorang · 2024-11-25T00:59:38Z

op-batcher/batcher/channel_manager.go

@@ -260,6 +260,10 @@ func (s *channelManager) processBlocks() error {
 		if s.currentChannel.IsFull() {
 			break
 		}
+		if s.rollupCfg.KromaMPTTime != nil && block.Time() == *s.rollupCfg.KromaMPTTime-s.rollupCfg.BlockTime {
+			s.currentChannel.channelBuilder.setFullErr(errors.New("reached the block just before KromaMPTTime"))


It would be nice to declare it in the channel builder file along with the other errors.

kangsorang · 2024-11-25T01:04:32Z

op-batcher/batcher/channel_manager.go

+		if s.rollupCfg.KromaMPTTime != nil && block.Time() == *s.rollupCfg.KromaMPTTime-s.rollupCfg.BlockTime {
+			s.currentChannel.channelBuilder.setFullErr(errors.New("reached the block just before KromaMPTTime"))


Since setFullErr is a managed function of the channelBuilder, why not handle this logic in the AddBlock of the channelBuilder?

sm-stack

How about changing the commit name to feat(batcher): send batcher transaction right before KromaMPTTime ?

op-batcher/batcher/channel_manager.go

sm-stack

LGTM

op-batcher/batcher/channel_builder.go

Pangssu added 4 commits November 9, 2024 14:04

feat: handle mpt transition time

3a037f8

feat: separate DepositTx into OP version and Kroma version

11f2c8f

fix: resolve test failures due to different deposit tx types

7e8fc98

feat: set suggested fee recipient for payload attributes

3473ad1

0xbenyun requested a review from a team as a code owner November 18, 2024 06:54

0xbenyun changed the title ~~feat(batcher): modify batcher to immediately submit batch transaction…~~ feat(batcher): modify batcher to immediately submit batch transaction just before KromaMPTTime Nov 18, 2024

0xbenyun marked this pull request as draft November 21, 2024 01:00

0xbenyun force-pushed the feat/batch-submission-mpttime branch from bd07942 to 62f7667 Compare November 22, 2024 00:53

0xbenyun changed the title ~~feat(batcher): modify batcher to immediately submit batch transaction just before KromaMPTTime~~ feat(batcher): immediately submit batcher tx just before KromaMPTTime Nov 22, 2024

0xbenyun force-pushed the feat/batch-submission-mpttime branch 2 times, most recently from ab1e59a to 7716f5c Compare November 22, 2024 05:42

0xbenyun marked this pull request as ready for review November 22, 2024 05:59

0xbenyun changed the title ~~feat(batcher): immediately submit batcher tx just before KromaMPTTime~~ feat(batcher): submit batcher tx just before KromaMPTTime Nov 22, 2024

0xbenyun changed the title ~~feat(batcher): submit batcher tx just before KromaMPTTime~~ feat(batcher): submit batcher tx just before KromaMPTTime. Nov 22, 2024

0xbenyun changed the title ~~feat(batcher): submit batcher tx just before KromaMPTTime.~~ feat(batcher): submit batcher tx just before KromaMPTTime Nov 22, 2024

0xbenyun force-pushed the feat/batch-submission-mpttime branch 3 times, most recently from 0ec3c25 to 89ee103 Compare November 22, 2024 07:00

kangsorang changed the title ~~feat(batcher): submit batcher tx just before KromaMPTTime~~ feat: submit batcher tx just before KromaMPTTime Nov 22, 2024

0xbenyun changed the title ~~feat: submit batcher tx just before KromaMPTTime~~ feat(batcher): submit batcher transaction right before mpt-migration time Nov 22, 2024

kangsorang changed the title ~~feat(batcher): submit batcher transaction right before mpt-migration time~~ feat: submit batcher transaction right before mpt-migration time Nov 22, 2024

0xbenyun force-pushed the feat/batch-submission-mpttime branch 2 times, most recently from e87e3bc to b08a314 Compare November 22, 2024 07:04

kangsorang reviewed Nov 25, 2024

View reviewed changes

sm-stack reviewed Nov 25, 2024

View reviewed changes

op-batcher/batcher/channel_manager.go Outdated Show resolved Hide resolved

0xbenyun force-pushed the feat/batch-submission-mpttime branch from dcc04fe to 83a7b05 Compare November 25, 2024 06:35

Pangssu changed the title ~~feat: submit batcher transaction right before mpt-migration time~~ feat(batcher): send batcher transaction right before KromaMPTTime Nov 26, 2024

0xbenyun requested a review from a team November 27, 2024 07:52

Pangssu approved these changes Nov 28, 2024

View reviewed changes

sm-stack approved these changes Nov 29, 2024

View reviewed changes

seolaoh reviewed Nov 29, 2024

View reviewed changes

op-batcher/batcher/channel_builder.go Outdated Show resolved Hide resolved

sm-stack mentioned this pull request Dec 2, 2024

feat: change predeploy contract addresses kroma-network/go-ethereum#125

Open

feat(batcher): send batcher transaction right before KromaMPTTime

1737b2b

0xbenyun force-pushed the feat/batch-submission-mpttime branch from 4b9f74f to 1737b2b Compare December 2, 2024 07:58

seolaoh approved these changes Dec 2, 2024

View reviewed changes

Pangssu force-pushed the feat/separate-deposit-tx branch from 3473ad1 to dd9255c Compare December 2, 2024 08:48

Pangssu requested a review from a team as a code owner December 2, 2024 08:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(batcher): send batcher transaction right before KromaMPTTime #393

feat(batcher): send batcher transaction right before KromaMPTTime #393

0xbenyun commented Nov 18, 2024 •

edited

Loading

coderabbitai bot commented Nov 18, 2024

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

0xbenyun commented Nov 22, 2024 •

edited

Loading

kangsorang Nov 25, 2024

kangsorang Nov 25, 2024

sm-stack left a comment

sm-stack left a comment

		if s.rollupCfg.KromaMPTTime != nil && block.Time() == *s.rollupCfg.KromaMPTTime-s.rollupCfg.BlockTime {
		s.currentChannel.channelBuilder.setFullErr(errors.New("reached the block just before KromaMPTTime"))

feat(batcher): send batcher transaction right before KromaMPTTime #393

Are you sure you want to change the base?

feat(batcher): send batcher transaction right before KromaMPTTime #393

Conversation

0xbenyun commented Nov 18, 2024 • edited Loading

Description

coderabbitai bot commented Nov 18, 2024

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

0xbenyun commented Nov 22, 2024 • edited Loading

kangsorang Nov 25, 2024

Choose a reason for hiding this comment

kangsorang Nov 25, 2024

Choose a reason for hiding this comment

sm-stack left a comment

Choose a reason for hiding this comment

sm-stack left a comment

Choose a reason for hiding this comment

0xbenyun commented Nov 18, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

0xbenyun commented Nov 22, 2024 •

edited

Loading