refac(math): mark classname as a mandatory argument

kroma-network · Sep 25, 2023 · 55c80a6 · 55c80a6
1 parent f13013e
commit 55c80a6
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/tachyon/math/finite_fields/generator/build_defs.bzl b/tachyon/math/finite_fields/generator/build_defs.bzl
@@ -5,12 +5,10 @@ def _generate_prime_field_impl(ctx):
     arguments = [
         "--out=%s" % (ctx.outputs.out.path),
         "--namespace=%s" % (ctx.attr.namespace),
+        "--class=%s" % (ctx.attr.class_name),
         "--modulus=%s" % (ctx.attr.modulus),
     ]
 
-    if len(ctx.attr.class_name) > 0:
-        arguments.append("--class=%s" % (ctx.attr.class_name))
-
     if len(ctx.attr.subgroup_generator):
         arguments.append("--subgroup_generator=%s" % (ctx.attr.subgroup_generator))
 

diff --git a/tachyon/math/finite_fields/generator/generator.cc b/tachyon/math/finite_fields/generator/generator.cc
@@ -331,7 +331,9 @@ int RealMain(int argc, char** argv) {
   parser.AddFlag<base::StringFlag>(&config.ns_name)
       .set_long_name("--namespace")
       .set_required();
-  parser.AddFlag<base::StringFlag>(&config.class_name).set_long_name("--class");
+  parser.AddFlag<base::StringFlag>(&config.class_name)
+      .set_long_name("--class")
+      .set_required();
   parser.AddFlag<base::StringFlag>(&config.modulus)
       .set_long_name("--modulus")
       .set_required();