feat(zk): enable pkey generation #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it would be more natural for |
chokobole
force-pushed
the
feat/enable-pkey-generation
branch
from
f11e8c3 to
3a1b43c
Compare
chokobole
force-pushed
the
feat/enable-pkey-generation
branch
from
3a1b43c to
ffe16f1
Compare
Since `Assembly` is only used to generate keys, this commit moves the file.
chokobole
force-pushed
the
feat/enable-pkey-generation
branch
from
ffe16f1 to
f77a70d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements keygen_pkxxx, while achieving both reducing code duplication and enhancing memory efficiency.
For reducing code duplication, it tries to share codes between
ProvingKeyandVerifyingKeyby moving some shared parts to a parent classKey.For enhancing memory efficiency, unlike Halo2, while computing
l_first,l_lastandl_active_row, it uses a single evaluations and recycles it.