feat: generalize transcript #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chokobole
force-pushed
the
feat/generalize-transcript
branch
5 times, most recently
from
b83226f to
d7314fa
Compare
Current `Transcript` assumes that its commitment type is an affine point. This commit breaks this assumption and it differentiates cases. 1. Commitment and Scalar are same types, such as FRI commitment cases. 2. Commitment and Scalar are different types, such as KZG commitment cases. Also `TranscriptReader` and `TranscriptWriter` child classes uses `Curve` type as a template parameter which is different from `Commitment` type from a parent class. This commit unifies template parameter for consistency as well. Other than above, it does as follows. - move halo2 specific things to `zk/plonk/halo2`. - remove `Challenge255` which leads to removing `SqueezeChallengeAsScalar()`. - rename `ReadScalar()` and `ReadPoint()` to `ReadFromProof()` for consistency with `WriteToProof()` and `WriteToTranscript()`. - remove unused headers from transcript implementation.
chokobole
force-pushed
the
feat/generalize-transcript
branch
from
d7314fa to
e6c6844
Compare
Insun35
reviewed
Dec 15, 2023
Insun35
reviewed
Dec 15, 2023
Insun35
reviewed
Dec 15, 2023
Insun35
reviewed
Dec 15, 2023
chokobole
force-pushed
the
feat/generalize-transcript
branch
from
b70c157 to
c01b1de
Compare
chokobole
force-pushed
the
feat/generalize-transcript
branch
from
c01b1de to
2f965fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Current
Transcriptassumes that its commitment type is an affine point. This commit breaks this assumption and it differentiates cases.Also
TranscriptReaderandTranscriptWriterchild classes usesCurvetype as a template parameter which is different fromCommitmenttype from a parent class. This commit unifies template parameter for consistency as well.Other than above, it does as follows.
zk/plonk/halo2.Challenge255.ReadScalar()andReadPoint()toReadFromProof()for consistency withWriteToProof()andWriteToTranscript().