feat: support halo2 proof encoding #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fakedev9999
reviewed
Dec 15, 2023
chokobole
force-pushed
the
feat/support-halo2-proof-encoding
branch
from
71f78c3 to
9a70ca3
Compare
chokobole
force-pushed
the
feat/support-halo2-proof-encoding
branch
from
9a70ca3 to
6d3b60c
Compare
Insun35
reviewed
Dec 17, 2023
chokobole
force-pushed
the
feat/support-halo2-proof-encoding
branch
2 times, most recently
from
874a910 to
e130452
Compare
Halo2 encodes point with a compression making use of a spare bit of base field. But our copyable was a just memory copy including y and infinity flag. To match with an outcome of Halo2 and furthermore support various encoding scheme, `Transcript` class delegates encoding to a child class.
chokobole
force-pushed
the
feat/support-halo2-proof-encoding
branch
from
e130452 to
74573b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Halo2 encodes point with a compression making use of a spare bit of base field. But our copyable was a just memory copy including y and infinity flag. To match with an outcome of Halo2 and furthermore support various encoding scheme,
Transcriptclass delegates encoding to a child class