feat: implement proof verification #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chokobole
force-pushed
the
feat/implement-proof-verification
branch
2 times, most recently
from
22dd3c9 to
4db2822
Compare
`kNumCoeffs` is not a number for domain dimension!
Since we generally don't support APIs for iterator and our parallelization api doens't suppport for iterator, I removed this APIs. Plus, our code doesn't depend on it, either. But if I use it everywhere, unittests are failed because of timeout!
chokobole
force-pushed
the
feat/implement-proof-verification
branch
from
4db2822 to
05de4d1
Compare
Note that this doesn't include pairing part yet.
Note that this doesn't include pairing part yet. See [verify_proof()](https://github.com/kroma-network/halo2/blob/7d0a36990452c8e7ebd600de258420781a9b7917/halo2_proofs/src/plonk/verifier.rs#L76-L240).
chokobole
force-pushed
the
feat/implement-proof-verification
branch
2 times, most recently
from
20d11ed to
8982337
Compare
Insun35
reviewed
Dec 20, 2023
Insun35
reviewed
Dec 20, 2023
What `halo2::Verifier` does is some validation done from halo2 `verify_proof` function and read proof using `halo2::ProofReader`. See [verify_proof()](https://github.com/kroma-network/halo2/blob/7d0a36990452c8e7ebd600de258420781a9b7917/halo2_proofs/src/plonk/verifier.rs#L41-L70).
Note that this doesn't include pairing part yet.
chokobole
force-pushed
the
feat/implement-proof-verification
branch
from
8982337 to
295e50c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements proof verification verify_proof() part. This doesn't include pairing part which involves evaluating expression.
Plus, it includes some optimizaitons.
ConstraintSystem::ComputeDegree()andConstraintSystem::ComputeBlindingFactors()by caching.UnivariateEvaluationDomain::GetElements().Ring::SumOfProducts()