Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(zk): implement proof verification part2 #208

Merged
merged 10 commits into from
Jan 5, 2024
Merged

feat(zk): implement proof verification part2 #208

merged 10 commits into from
Jan 5, 2024

Conversation

chokobole
Copy link
Contributor

Description

This PR implements expecetd_h computation.

@chokobole chokobole changed the title Feat/implement proof verification part2 feat(zk): implement proof verification part2 Dec 20, 2023
dongchangYoo
dongchangYoo approved these changes Dec 20, 2023
View reviewed changes
Copy link
Contributor

@dongchangYoo dongchangYoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chokobole chokobole force-pushed the feat/implement-proof-verification-part2 branch from c849e77 to 4207f87 Compare December 20, 2023 06:13
@chokobole chokobole force-pushed the feat/implement-proof-verification-part2 branch 2 times, most recently from 4322592 to b550240 Compare December 20, 2023 06:32
Insun35
Insun35 approved these changes Dec 20, 2023
View reviewed changes
Copy link
Contributor

@Insun35 Insun35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chokobole chokobole force-pushed the feat/implement-proof-verification-part2 branch from b550240 to fdf8e1b Compare December 21, 2023 04:48
fakedev9999
fakedev9999 requested changes Jan 4, 2024
View reviewed changes
tachyon/zk/plonk/permutation/permutation_utils.h Show resolved Hide resolved
tachyon/zk/plonk/halo2/verifier.h Outdated Show resolved Hide resolved
tachyon/zk/plonk/permutation/BUILD.bazel Outdated Show resolved Hide resolved
tachyon/zk/plonk/permutation/permutation_utils.h Show resolved Hide resolved
tachyon/zk/plonk/permutation/permutation_verification.h Show resolved Hide resolved
tachyon/zk/plonk/permutation/permutation_verification.h Show resolved Hide resolved
tachyon/zk/plonk/permutation/permutation_verification.h Outdated Show resolved Hide resolved
tachyon/zk/lookup/lookup_verification.h Show resolved Hide resolved
tachyon/zk/lookup/lookup_verification.h Show resolved Hide resolved
@chokobole chokobole force-pushed the feat/implement-proof-verification-part2 branch from fdf8e1b to 28a054a Compare January 4, 2024 23:34
chokobole added 10 commits January 5, 2024 08:34
@chokobole
refac(zk): add NOTREACHED() with error statements more clearly as h…
5d425f6 
…alo2

See https://github.com/kroma-network/halo2/blob/7d0a36990452c8e7ebd600de258420781a9b7917/halo2_proofs/src/plonk/evaluation.rs#L825
@chokobole
fix(zk): add missing dep and hdr to SelectorReplacer
079798e
@chokobole
refac(zk): extract common code to ComputePermutationChunkLength()
2cdc018
@chokobole
refac(zk): add some utils to compute permutation product nums
8650b56
@chokobole
feat(zk): implement VanishingVerificationEvaluator
4e33465 
See
https://github.com/kroma-network/halo2/blob/7d0a36990452c8e7ebd600de258420781a9b7917/halo2_proofs/src/plonk/verifier.rs#L271-L283.
@chokobole
chore(zk): use greek small letter data unicodes for consistency
a25b9f2
@chokobole
refac(zk): move GetDelta() to permutation_utils.h
a4b9245
@chokobole
feat(zk): implement permutation verification evaluations
0725d13 
See [Evaluated<C>::expressions()](https://github.com/kroma-network/halo2/blob/7d0a36990452c8e7ebd600de258420781a9b7917/halo2_proofs/src/plonk/permutation/verifier.rs#L105-L204).
@chokobole
refac(zk): do not return boolean if the function always return true
4f8a2a2
@chokobole
feat(zk): implement lookup verification evaluations
cec9c1e 
See [Evaluated<C>::expressions()](https://github.com/kroma-network/halo2/blob/7d0a36990452c8e7ebd600de258420781a9b7917/halo2_proofs/src/plonk/lookup/verifier.rs#L92-L168).
@chokobole chokobole force-pushed the feat/implement-proof-verification-part2 branch from 28a054a to cec9c1e Compare January 4, 2024 23:50
@fakedev9999 fakedev9999 mentioned this pull request Jan 5, 2024
Open
fakedev9999
fakedev9999 approved these changes Jan 5, 2024
View reviewed changes
Copy link
Contributor

@fakedev9999 fakedev9999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fakedev9999 fakedev9999 merged commit 7dd3f55 into main Jan 5, 2024
3 checks passed
@fakedev9999 fakedev9999 deleted the feat/implement-proof-verification-part2 branch January 5, 2024 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fakedev9999 fakedev9999 fakedev9999 approved these changes

@Insun35 Insun35 Insun35 approved these changes

@dongchangYoo dongchangYoo dongchangYoo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chokobole @dongchangYoo @Insun35 @fakedev9999