Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: check node buildable using bazel condition #58

Merged
merged 1 commit into from
Sep 21, 2023

Conversation

chokobole
Copy link
Contributor

Description

This is more simple way to use macro.

@chokobole chokobole force-pushed the build/check-node-buildable-using-bazel-condition branch from e2cb7c7 to 1dda9d6 Compare September 21, 2023 03:20
@chokobole chokobole marked this pull request as ready for review September 21, 2023 03:20
Copy link
Contributor

@Leegwangwoon Leegwangwoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@fakedev9999 fakedev9999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chokobole chokobole merged commit bba38a4 into main Sep 21, 2023
3 checks passed
@chokobole chokobole deleted the build/check-node-buildable-using-bazel-condition branch September 21, 2023 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants