Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refac: refactor math #64

Merged
merged 2 commits into from
Sep 26, 2023
Merged

refac: refactor math #64

merged 2 commits into from
Sep 26, 2023

Conversation

chokobole
Copy link
Contributor

@chokobole chokobole commented Sep 26, 2023 •
edited by fakedev9999
Loading

Description

  1. This removes AdditiveIdentity and MultiplicativeIdentity.
  2. This removes Evaluate() and Degree() from Polyonimal<F>.

See the commit messages for more details!

@chokobole
refac(math): remove Evaluate() and Degree() from Polynomial<F>
4c039b7 
A function definition in `Polynomial<F>` doesn't help in any respects.
It's just a code duplication. In addition, a function signature of `Evaluate()`
is not matched to one in `MultivariatePolynomial<F>`.
@chokobole
refac(math): remove unused Additive|MultiplicativeIdentity
829209e 
They are added to support some features such as `Matrix::Identity()`
in the past. But thanks to #23, we don't need this anymore.
Without this, you can use `Eigen::Matrix<BaseField, 2, 2>::Identity()`
for identity matrix.

Related: #23
fakedev9999
fakedev9999 approved these changes Sep 26, 2023
View reviewed changes
Copy link
Contributor

@fakedev9999 fakedev9999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Leegwangwoon
Leegwangwoon approved these changes Sep 26, 2023
View reviewed changes
Copy link
Contributor

@Leegwangwoon Leegwangwoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Insun35
Insun35 approved these changes Sep 26, 2023
View reviewed changes
Copy link
Contributor

@Insun35 Insun35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chokobole chokobole merged commit 0e26c04 into main Sep 26, 2023
3 checks passed
@chokobole chokobole deleted the refac/refactor-math branch September 26, 2023 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Leegwangwoon Leegwangwoon Leegwangwoon approved these changes

@fakedev9999 fakedev9999 fakedev9999 approved these changes

@Insun35 Insun35 Insun35 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chokobole @Insun35 @fakedev9999 @Leegwangwoon