feat: prepare pairing #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chokobole
force-pushed
the
feat/prepare-pairing
branch
from
3461652 to
d8b9ed9
Compare
For the classes that inherits such as `Group<T>` or `Field<T>`, the type `T` is assumed to be the most derived class. This commit adds `final` keyword for this purpose.
chokobole
force-pushed
the
feat/prepare-pairing
branch
from
d8b9ed9 to
7c1b524
Compare
Insun35
reviewed
Oct 4, 2023
tachyon/math/polynomials/multivariate/multivariate_polynomial_unittest.cc
Outdated
Show resolved
Hide resolved
The range of `non_residue` exceeds definitely beyond `uint64_t`, it should be input with `std::string`.
This commit adds `BasePrimeField` to config class of `Extension Prime Field` and `SWCurve`.
…ld()` In addition, before this commit, `GenerateInitField()` generates field initialization only for `BaseField` and `ScalarField`. `GenerateInitExtField()` generates extension field initialization only for `BaseField`. Considering `Frobenius Coefficients`, this needs to expand to BaseField of BaseField. | Name | NonResidue | Frobenius Coefficient | |----------|------------|-----------------------------| | Fp2 | Fp | Fp(BaseField) | | Fp3 | Fp | Fp(BaseField) | | Fp4 | Fp2 | Fp(BaseField of BaseField) | | Fp6(2/3) | Fp3 | Fp(BaseField of BaseField) | | Fp6(3/2) | Fp2 | Fp2(BaseField) | | Fp12 | Fp6 | Fp2(BaseField of BaseField) |
chokobole
force-pushed
the
feat/prepare-pairing
branch
from
7c1b524 to
b97734b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These are simple changes without mathematical feature addition during implementing pairing.