Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Update golang.org/x/net #499

Merged
merged 2 commits into from
Apr 22, 2024
Merged

chore: Update golang.org/x/net #499

merged 2 commits into from
Apr 22, 2024

Conversation

spolti
Copy link
Contributor

@spolti spolti commented Apr 12, 2024 •
edited by rafvasq
Loading

[RHOAIENG-5305] - golang.org/x/net Allocation of Resources Without Limits or Throttling

chore: Fixes CVE-2023-45288

@oss-prow-bot oss-prow-bot bot requested review from ckadner, joerunde and njhill April 12, 2024 19:23
@rafvasq rafvasq changed the title [RHOAIENG-5305] - golang.org/x/net Allocation of Resources Without Li… chore: Update golang.org/x/net Apr 18, 2024
@rafvasq rafvasq requested review from rafvasq and removed request for joerunde April 18, 2024 18:00
@rafvasq
Copy link
Member

rafvasq commented Apr 18, 2024

Thanks @spolti, please resolve conflicts when you get a chance to.

@spolti
Copy link
Contributor Author

spolti commented Apr 18, 2024

Done, thanks for the heads up.

@spolti
Copy link
Contributor Author

spolti commented Apr 19, 2024

It seems to be a instability in the tests.

@spolti
empty commit
7b0e629 
Signed-off-by: Spolti <[email protected]>
@israel-hdez
Copy link
Collaborator

@rafvasq @ckadner Please, take a look when you can, so that I can move forward with v0.12.

rafvasq
rafvasq approved these changes Apr 22, 2024
View reviewed changes
Copy link
Member

@rafvasq rafvasq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @spolti

/lgtm

@oss-prow-bot oss-prow-bot bot added the lgtm label Apr 22, 2024
@oss-prow-bot OSS-prow-bot
Copy link

oss-prow-bot bot commented Apr 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: israel-hdez, rafvasq, spolti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@oss-prow-bot OSS-prow-bot
Copy link

oss-prow-bot bot commented Apr 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: israel-hdez, rafvasq, spolti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rafvasq rafvasq merged commit 331a89d into kserve:main Apr 22, 2024
7 checks passed
@spolti spolti deleted the xnet branch April 23, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@israel-hdez israel-hdez israel-hdez approved these changes

@rafvasq rafvasq rafvasq approved these changes

@ckadner ckadner Awaiting requested review from ckadner

@njhill njhill Awaiting requested review from njhill

Assignees

@rafvasq rafvasq

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@spolti @rafvasq @israel-hdez