Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow external hpa #520

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

robinvd
Copy link

@robinvd robinvd commented Jul 16, 2024

Motivation

We need automatic scaling for servingruntimes based on some gpu load metric. The default deployment included metrics including prometheus. Using keda we want to scale based on prometheus queries.

The current options for scaling are

  • static based on replicas in the servingruntime/config
  • dynamic using hpa annotation. But this creates a managed hpa that only works with the buildin kubernetes metrics. Adding another hpa will conflict with the already created one.

This PR adds the external option where the controller wont set the replicas and wont create an hpa.

Modifications

The already existing External AutoscalerClass is now checked for instead of crashing the controller. The behavior is the same as None except it does not set the replicas property.

Result

potentially/partially solves #372

@oss-prow-bot oss-prow-bot bot requested review from ckadner, rafvasq and njhill July 16, 2024 11:04
Copy link

oss-prow-bot bot commented Jul 16, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: robinvd
Once this PR has been reviewed and has the lgtm label, please assign rafvasq for approval by writing /assign @rafvasq in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
Copy link

oss-prow-bot bot commented Jul 16, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: robinvd
Once this PR has been reviewed and has the lgtm label, please assign rafvasq for approval by writing /assign @rafvasq in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@oss-prow-bot oss-prow-bot bot requested a review from rafvasq July 16, 2024 11:04
@robinvd robinvd force-pushed the allow-external-hpa branch from f38c91d to 2ea3c3c Compare July 16, 2024 12:07
Signed-off-by: Robin <[email protected]>
@robinvd robinvd force-pushed the allow-external-hpa branch from 2ea3c3c to 8e46c1c Compare July 16, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant