Update kubernetes_deployment.md #398
Conversation
fixes: kserve#383 Signed-off-by: Rajakavitha Kodhandapani <[email protected]>
✅ Deploy Preview for elastic-nobel-0aef7a ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
fixed formatting Signed-off-by: Rajakavitha Kodhandapani <[email protected]>
format Signed-off-by: Rajakavitha Kodhandapani <[email protected]>
| "disableIngressCreation": true, | ||
| "ingressDomain": "svc.cluster.local", | ||
| "ingressGateway" : "disabled", | ||
| "ingressService" : "disabled" |
There was a problem hiding this comment.
here we also need to set the default ingressClass otherwise you will need to do everything manually later.
If the reason is to decouple from Istio, most of k8s cluster have a default one, we need to give this info to the user e.g. minikube uses nginx.
Instead disabling the ingress would be better to explain both options.
There was a problem hiding this comment.
Please suggest what change needs to be made to the yaml file.
There was a problem hiding this comment.
@spolti Can you provide some suggested verbiage here for @Rajakavitha1?
There was a problem hiding this comment.
it is described a few lines below, one of the removed.
btw @terrytangyuan, shouldn't we have a specific section for raw?
Instead of deleting the istio part, we should instead document both ways.
Istio is required for serverless and it is the default method.
You could change the beginning of the doc like keeping the requirements for the Serverless mode, and later, explain what is the RawDeployment (like it is done now) and describe the steps needed to install it.
There was a problem hiding this comment.
"disableIstioVirtualHost": true,
"disableIngressCreation": true,
"ingressGateway" : "disabled",
"ingressService" : "disabled"
I have a few questions regarding this configuration.
Isn't it true that the controller already handles these aspects? In other words, when using rawDeployment, these related calls may not even be triggered. Should we really be making changes in this area?
"ingressDomain": "svc.cluster.local",
this would be needed.
"defaultDeploymentMode": "RawDeployment"
Additionally, I understand that this setting implies using rawDeployment as the default, but it doesn't mean that only rawDeployment will be used. I think this configuration might still be necessary when setting the serverlessMode in isvc.
Lastly, shouldn't the disableIngressCreation be set to false instead? does the ingress need not to be created?
| @@ -1,52 +1,55 @@ | |||
| # Kubernetes Deployment Installation Guide | |||
| KServe supports `RawDeployment` mode to enable `InferenceService` deployment with Kubernetes resources [`Deployment`](https://kubernetes.io/docs/concepts/workloads/controllers/deployment), [`Service`](https://kubernetes.io/docs/concepts/services-networking/service), [`Ingress`](https://kubernetes.io/docs/concepts/services-networking/ingress) and [`Horizontal Pod Autoscaler`](https://kubernetes.io/docs/tasks/run-application/horizontal-pod-autoscale). Comparing to serverless deployment it unlocks Knative limitations such as mounting multiple volumes, on the other hand `Scale down and from Zero` is not supported in `RawDeployment` mode. | |||
|
|
|||
| Kubernetes 1.22 is the minimally required version and please check the following recommended Istio versions for the corresponding | |||
There was a problem hiding this comment.
My understanding was that Istio was not required The current installation guide for raw deployment mode is not accurate. For example, Istio is not needed if disableIngressCreation is enabled. See https://github.com/kserve/kserve/pull/3436
There was a problem hiding this comment.
Yes, raw does not require it, but for the serverless mode the docs advises to use it, iirc.
fixes: #383
"Fixes #383 " or "Add description of the problem this PR solves"
Proposed Changes