Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MainActivity: Remove unused code and comments #445

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

ksharma-xyz
Copy link
Owner

@ksharma-xyz ksharma-xyz commented Dec 9, 2024

TL;DR

Cleaned up MainActivity by removing unused code and comments

What changed?

  • Removed commented-out code related to Koin configuration and Android application components
  • Simplified the MainActivity class to only contain essential functionality
  • Maintained core functionality with enableEdgeToEdge() and KrailApp() setup

How to test?

  1. Launch the application
  2. Verify that the app starts and runs normally
  3. Confirm that edge-to-edge display still functions correctly

Why make this change?

Improves code maintainability by removing dead code and unused comments that were likely remnants from previous implementations. This makes the codebase cleaner and easier to understand while reducing technical debt.

Copy link
Owner Author

ksharma-xyz commented Dec 9, 2024

@ksharma-xyz ksharma-xyz changed the title Cleanup main activity MainActivity: Remove unused code and comments Dec 9, 2024
@ksharma-xyz ksharma-xyz marked this pull request as ready for review December 9, 2024 11:32
Copy link
Owner Author

ksharma-xyz commented Dec 9, 2024

Merge activity

  • Dec 9, 6:32 AM EST: A user started a stack merge that includes this pull request via Graphite.
  • Dec 9, 6:32 AM EST: A user merged this pull request with Graphite.

@ksharma-xyz ksharma-xyz merged commit 44b9fe5 into main Dec 9, 2024
2 checks passed
@ksharma-xyz ksharma-xyz deleted the 12-09-cleanup_main_activity branch December 9, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant