-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes #67 Hot-reload the code in the containers #69
Conversation
* Add the Docker `developer` option to live-update the files inside the containers for frontend and backend. * Add the `development` section to the backend Dockerfile. This section is run with docker-compose. * Adjusted the npm `dev` command to include the host and the port. * Removed unused import on frontend.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have put in some minor questions. One more thing is that it might be worth to mention in README that You need to be logged into Docker Desktop to use --watch, it does not work for anonymous users
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have put in some minor questions. One more thing is that it might be worth to mention in README that You need to be logged into Docker Desktop to use --watch, it does not work for anonymous users
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have put in some minor questions. One more thing is that it might be worth to mention in README that You need to be logged into Docker Desktop to use --watch, it does not work for anonymous users
According to the official Docker website, the sign-in benefits are just some more pull ranges. |
Quality Gate passed for 'ksummarized_ksummarized.com_frontend'Issues Measures |
You are right. I have just retried it after logging out and this time it worked 🤷🏼 Maybe some issue on my side before. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚢
developer
option to live-update the files inside the containers for frontend and backend.development
section to the backend Dockerfile. This section is run with docker-compose.dev
command to include the host and the port.