-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New build passing badge #142
Conversation
@andreaslindner , could you take a look at the reason for the below when you have time: HolBA/scripts/setup/env_config_gen.sh Lines 42 to 43 in 846fb86
Ironically, this commit caused the build to fail due to this check. |
I didn't add the badge because it is almost non-sense. Browsers cache these images and thus a failing check (because of the weird deadlocks that sometimes happen for example) may stay preserved for very long. Likewise, a successful check may be preserved. As I see it this is a non-sense feature that everybody adds. Especially since it is added by more maintained projects that keep it always passing. The information content of this is near zero and because many add it, it has kind of a status value. That being said, I am not against if you want to have it. You can simply change the check in |
I changed the position of the badge, which made the "bad README" check pass. I've seen both positions in other repositories, I think this also looks nice. I was going through some earlier issues earlier and did this very quick PR in response to #103, I didn't recall any opinions on this matter from previously. Personally, I think the README should look nice and be useful for visitors, so even if things don't make a lot of sense for us (we know builds on main branch pass CI) it might still serve a purpose in the README file. There are also some other badges we might consider adding later, like for example the Zulip chat link if we should choose to migrate to that platform. |
Yes, that could be also useful if we plan to have a channel for the general public or similar. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
I added a new CI badge to the top. This looks nice, I think.