Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KTOR-7962 Fix fullstack-mpp sample #209

Merged
merged 7 commits into from
Dec 18, 2024
Merged

Conversation

stokado
Copy link
Contributor

@stokado stokado commented Dec 15, 2024

Summary

This PR aims to fix failing build of the fullstack-mpp sample.

Approach

Set npm "ws" latest version explicitly.
I believe, after ktor 3.0.3 release we can remove that dependency in build.gradle.kts.

fullstack-mpp/build.gradle.kts Fixed Show fixed Hide fixed
fullstack-mpp/build.gradle.kts Dismissed Show dismissed Hide dismissed
import io.ktor.client.engine.js.*
import io.ktor.client.request.*
import io.ktor.http.*
import io.ktor.samples.fullstack.common.*
import kotlinx.browser.document
import kotlinx.browser.window
import kotlinx.browser.*

Check warning

Code scanning / detekt

Wildcard imports should be replaced with imports using fully qualified class names. Wildcard imports can lead to naming conflicts. A library update can introduce naming clashes with your classes which results in compilation errors. Warning

kotlinx.browser.* is a wildcard import. Replace it with fully qualified imports.
Copy link
Member

@osipxd osipxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Than you for the Pull Request! Migration to Kotlin DSL is a great idea! I have just a couple of minor comments.

fullstack-mpp/build.gradle.kts Outdated Show resolved Hide resolved
fullstack-mpp/build.gradle.kts Outdated Show resolved Hide resolved
fullstack-mpp/build.gradle.kts Outdated Show resolved Hide resolved
@@ -0,0 +1,83 @@
import org.jetbrains.kotlin.gradle.targets.js.webpack.*

Check warning

Code scanning / detekt

Wildcard imports should be replaced with imports using fully qualified class names. Wildcard imports can lead to naming conflicts. A library update can introduce naming clashes with your classes which results in compilation errors. Warning

org.jetbrains.kotlin.gradle.targets.js.webpack.* is a wildcard import. Replace it with fully qualified imports.
Co-authored-by: Osip Fatkullin <[email protected]>
@osipxd osipxd self-requested a review December 17, 2024 20:42
Copy link
Member

@osipxd osipxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done! Thank you for your contribution 🎉

@osipxd osipxd merged commit 302bca8 into ktorio:main Dec 18, 2024
20 of 24 checks passed
@stokado stokado deleted the fix/KTOR-7962 branch December 21, 2024 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants