-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KTOR-7962 Fix fullstack-mpp sample #209
Conversation
import io.ktor.client.engine.js.* | ||
import io.ktor.client.request.* | ||
import io.ktor.http.* | ||
import io.ktor.samples.fullstack.common.* | ||
import kotlinx.browser.document | ||
import kotlinx.browser.window | ||
import kotlinx.browser.* |
Check warning
Code scanning / detekt
Wildcard imports should be replaced with imports using fully qualified class names. Wildcard imports can lead to naming conflicts. A library update can introduce naming clashes with your classes which results in compilation errors. Warning
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Than you for the Pull Request! Migration to Kotlin DSL is a great idea! I have just a couple of minor comments.
@@ -0,0 +1,83 @@ | |||
import org.jetbrains.kotlin.gradle.targets.js.webpack.* |
Check warning
Code scanning / detekt
Wildcard imports should be replaced with imports using fully qualified class names. Wildcard imports can lead to naming conflicts. A library update can introduce naming clashes with your classes which results in compilation errors. Warning
Co-authored-by: Osip Fatkullin <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done! Thank you for your contribution 🎉
Summary
This PR aims to fix failing build of the fullstack-mpp sample.
Approach
Set npm "ws" latest version explicitly.
I believe, after ktor 3.0.3 release we can remove that dependency in build.gradle.kts.