KTOR-7952 Fix for uninitialized writerJob property #4559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjhham
force-pushed
the
bjhham/lateinit-writerjob-fix
branch
2 times, most recently
from
085bf3b to
cfba409
Compare
bjhham
force-pushed
the
bjhham/lateinit-writerjob-fix
branch
from
072f3a2 to
665163b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subsystem
Client, SaveBody
Motivation
KTOR-7952 SaveBodyPlugin: UninitializedPropertyAccessException when reading response body within receivePipeline
Solution
Using a lazy delegate instead of a lateinit variable will make it so it will always get initialized - either from
copyTask.start()or fromawaitImpatiently().