vmm:qemu support config_qemu.toml #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xukobe
reviewed
Oct 30, 2024
vmm/sandbox/config_qemu_x86_64.toml
Outdated
| cpu_features = "pmu=off" | ||
| cpu_model = "host" | ||
| qemu_path = "/usr/bin/qemu-system-x86_64" | ||
| machine_type = "virt" |
There was a problem hiding this comment.
please check this machine type, I believe it should be 'pc' instread
vmm/sandbox/config_qemu_aarch64.toml
Outdated
| vcpus = 1 | ||
| kernel_params = "task.log_level=debug task.sharefs_type=9p tsc=reliable rcupdate.rcu_expedited=1 i8042.direct=1 i8042.dumbkbd=1 i8042.nopnp=1 i8042.noaux=1 noreplace-smp= reboot=k console=hvc0 console=hvc1 iommu=off cryptomgr.notests= net.ifnames=0 pci=lastbus=0" | ||
| kernel_path = "/var/lib/kuasar/vmlinux.bin" | ||
| initrd_path = "/var/lib/kuasar/kuasar.img" |
There was a problem hiding this comment.
kuasar.img is built as rootfs image in the cargo.toml above, it shouldn't be here as initrd. please either use a real initrd image or put kuasar.img in the image_path.
vmm/sandbox/config_qemu_x86_64.toml
Outdated
| vcpus = 1 | ||
| kernel_params = "task.log_level=debug task.sharefs_type=9p tsc=reliable rcupdate.rcu_expedited=1 i8042.direct=1 i8042.dumbkbd=1 i8042.nopnp=1 i8042.noaux=1 noreplace-smp= reboot=k console=hvc0 console=hvc1 iommu=off cryptomgr.notests= net.ifnames=0 pci=lastbus=0" | ||
| kernel_path = "/var/lib/kuasar/vmlinux.bin" | ||
| initrd_path = "/var/lib/kuasar/kuasar.img" |
abel-von
reviewed
Nov 4, 2024
vmm/sandbox/config_qemu_aarch64.toml
Outdated
| share_fs = "Virtio9P" | ||
| use_vsock = true | ||
|
|
||
| [hypervisor.common] |
There was a problem hiding this comment.
Can we put all these configs under [hypervisor] in the toml?
abel-von
approved these changes
Nov 4, 2024
|
LGTM |
Signed-off-by: liuxu <[email protected]>
HITweihailiuxu
force-pushed
the
main
branch
2 times, most recently
from
115295f to
313c2a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vmm:qemu support config_qemu.toml