wasm: add kuasar-wasm systemd service #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please rebase your commits. |
flyflypeng
reviewed
Sep 11, 2023
wasm/service/kuasar-wasm.service
Outdated
| [Service] | ||
| Type=simple | ||
| ExecStart=/usr/local/bin/wasm-sandboxer --listen /run/wasm-sandboxer.sock --dir /run/kuasar-wasm | ||
| ExecReload=/bin/kill -s HUP $MAINPID |
There was a problem hiding this comment.
Currently wasm type sandboxer doesn't support config reload feature, ExecReload needs to be removed.
There was a problem hiding this comment.
What is the consequence of keeping this ExecReload?
There was a problem hiding this comment.
If the user runs the systemctl reload wasm-sandboxer command, the wasm-sandboxer process will receive the SIGHUP signal and process exit abnornally, which does not meet the expectation of the systemctl reload command.
Signed-off-by: jwcesign <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wasm: add kuasar-wasm systemd service