feat(deployment): Enhance Docker ImagePull Secrets Configuration

[janavenkat]

In larger production environments, we may get rate-limited by Docker Hub for a lot of image pulls. So, I've added an option for providing the Docker pull secret name to avoid rate limits.

Purpose of PR?:

Add option for passing docker pull secrets in helm template

Does this PR introduce a breaking change?
No

**If the changes in this PR are manually verified, list down the scenarios covered::
Using helm template

Checklist:

• Bug fix. Fixes #
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update
• PR Title follows the convention of <type>(<scope>): <subject>
• Commit has unit tests
• Commit has integration tests

[rksharma95]

@janavenkat thanks for the PR, Lets extend the imagePullSecret configuration to operator deployment model as well. Let me know if anything is needed from my side.

[janavenkat]

@janavenkat thanks for the PR, Lets extend the imagePullSecret configuration to operator deployment model as well. Let me know if anything is needed from my side.

Sure will add changes for operator as well.

[janavenkat]

@janavenkat thanks for the PR, Lets extend the imagePullSecret configuration to operator deployment model as well. Let me know if anything is needed from my side.

Added for Operator as well

[nyrahul]

@rksharma95 @daemon1024 , can you please review this PR? Thanks

[rksharma95]

@janavenkat changes looks good assuming that kubearmor helm chart is being used to deploy.

operator uses get pkg to generate kubearmor resources and it will require to add this change there to be in effect.

we've a in-progress action item of major refactoring of kubearmor-operator #1779 we can take care of this feature request as part of it. thanks for your suggestion

[janavenkat]

@rksharma95 @daemon1024 can we merge this PR?

[Prateeknandle]

please remove default tolerations present in daemonset, which make kubearmor available in tainted nodes, without explicitly adding toleration for them.

default toleration is:

      tolerations:
      - operator: Exists

[Prateeknandle]

Initially when we define globalTolerations and globalImagePullSecrets through kubearmorconfig it is not reflected in deployments or daemonset, after some update in config when we again apply it, then it is getting reflected.

After reflecting the changes in deployments and daemonset, I've seen expected behaviour.

Kindly look into this as well.