-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(operator): fetch cluster name from providers #1881
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what happens in case there is no operator, should we have a fallback logic in kubearmor?
cc: @daemon1024
Yes, cluster name goes to "default". |
@rootxrishabh i meant shouldn't we fetch cluster name from providers in case operator is not there? |
@rootxrishabh can you please add args handling in operator helm chart? It should support any args list values. |
c4ae336
to
0251593
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on both GKE and AWS, working as expected.
@Prateeknandle @rootxrishabh does kubearmor uses |
No, sry totally forgot this point, @rootxrishabh we should update cluster name in kubearmor, it should get updated based on conifgmap value. check whether correct cluster name is reflected in alerts/logs or not. |
0251593
to
7863504
Compare
7863504
to
80bfbae
Compare
80bfbae
to
54fdc85
Compare
Signed-off-by: Rishabh Soni <[email protected]> Add support for EKS Signed-off-by: Rishabh Soni <[email protected]> Remove AKS reference Signed-off-by: Rishabh Soni <[email protected]> Make provider hostname and endpoint configurable Signed-off-by: Rishabh Soni <[email protected]> Make provider hostname and endpoint configurable Signed-off-by: Rishabh Soni <[email protected]>
54fdc85
to
d544d58
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Purpose of PR?:
This PR adds fetching cluster name from cluster providers.
Does this PR introduce a breaking change?
No
If the changes in this PR are manually verified, list down the scenarios covered::
Additional information for reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs
Checklist:
<type>(<scope>): <subject>