This repository has been archived by the owner on Sep 12, 2023. It is now read-only.
fix: add missing dependencies and missing methods #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
em.. Seems travis has been removed? see screenshot there. #141 introduces some build failures and I think that's the reason we didn't catch it in presubmit phase..
/cc @terrytangyuan @gaocegege anyone know who manages this? |
Jeffwan
changed the title
|
I have no idea about it. Should we use github actions? /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gaocegege The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@gaocegege Not sure what happened to travis. Agree, I create an issue to track it #162 |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address #161 #159
This is related to @zw0610 's reconciler v1 work.
I am trying to see if the CI can pass and why we didn't detect the failure earlier.