Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lehrig to the Member List #581

Merged
merged 2 commits into from
Jan 18, 2023
Merged

Conversation

lehrig
Copy link
Contributor

@lehrig lehrig commented Oct 25, 2022

I'm mainly known for my work on this: kubeflow/community#781

On my private github (https://github.com/lehrig), you will find lots of related, open-sourced Kubeflow contributions, which my team will now upstream step-by-step to the Kubeflow community.

@google-oss-prow
Copy link

Hi @lehrig. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lehrig
Copy link
Contributor Author

lehrig commented Jan 3, 2023

Sponsors:
@Tomcli
@animeshsingh
@juliusvonkohout

@juliusvonkohout
Copy link
Member

juliusvonkohout commented Jan 4, 2023

@lehrig yeah i am also working on it :-D #584

@lehrig
Copy link
Contributor Author

lehrig commented Jan 17, 2023

Added pytest output as mentioned at https://github.com/kubeflow/internal-acls/blob/master/.github/ISSUE_TEMPLATE/join_org.md

$ pytest test_org_yaml.py
====================================================================================================== test session starts =======================================================================================================
platform darwin -- Python 3.9.7, pytest-7.2.1, pluggy-1.0.0
rootdir: /Users/lehrig/git/internal-acls/github-orgs
collected 1 item                                                                                                                                                                                                                 

test_org_yaml.py .                                                                                                                                                                                                         [100%]

======================================================================================================= 1 passed in 0.19s ========================================================================================================

@zijianjoy
Copy link
Contributor

Hello @lehrig , please follow https://github.com/kubeflow/internal-acls#joining-kubeflow-github-organization which includes:

  • Provide 2-3 links to PRs or other contributions.
  • List 2 existing members who are sponsoring your membership.

@lehrig
Copy link
Contributor Author

lehrig commented Jan 17, 2023

@zijianjoy, here are those information again:

  • Provide 2-3 links to PRs or other contributions.

See first comment - I think this should suffice: kubeflow/community#781

  • List 2 existing members who are sponsoring your membership.

@Tomcli
@animeshsingh
@juliusvonkohout

@zijianjoy
Copy link
Contributor

/lgtm
/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lehrig, zijianjoy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 02dee78 into kubeflow:master Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants