Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup test automation for github org tests #678

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions .github/ISSUE_TEMPLATE/join_org.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,16 +13,6 @@ Please read the [guide lines](https://www.kubeflow.org/docs/about/contributing/#

** Please list 2 existing members who are sponsoring your membership:**

** Please test your PR **

Run

```
cd github_orgs
pytest test_org_yaml.py
```
Include the output in the PR

**Additional Instructions**

After your PR is merged please wait at least 1 hour for changes to propogate.
Expand Down
2 changes: 2 additions & 0 deletions .github/requirements.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
pytest==8.2.0
PyYAML==6.0.1
29 changes: 29 additions & 0 deletions .github/workflows/github_org_test.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
name: Github Org Tests
on:
pull_request:
paths:
- github-orgs/kubeflow/org.yaml
jobs:
tests:
runs-on: ubuntu-latest
env:
PYTHON_VERSION: "3.10"
steps:
- name: Checkout
uses: actions/checkout@v4

- name: Set up Python ${{ env.PYTHON_VERSION }}
uses: actions/setup-python@v5
with:
python-version: ${{ env.PYTHON_VERSION }}
cache: "pip"

- name: Install PyTest
run: |
pip install -r .github/requirements.txt
pytest --version

- name: Run tests
working-directory: ./github-orgs
run: |
pytest test_org_yaml.py
5 changes: 2 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@ Repository used to maintain group ACLs used by the Kubeflow community.

For Google Groups in kubeflow.org, refer to `google_groups` subfolder.

Run `pytest` after modifying `org.yaml`. Currently, this must be run
manually. This test run automatically in a future change.
To check if everything is fine after modifying `org.yaml`, you can run
`pytest` locally from `github-orgs` directory.

## Joining Kubeflow GitHub organization

Expand All @@ -21,7 +21,6 @@ To join the Kubeflow GitHub organization, complete the following steps:
cd github-orgs
pytest test_org_yaml.py
```
Include the output in the PR.

**Additional Instructions**

Expand Down