Skip to content

Commit

Permalink
fix: remove the dependency of protocmp in `google.golang.org/protob…
Browse files Browse the repository at this point in the history
…uf/testing/protocmp`. (#2391)

Signed-off-by: Electronic-Waste <[email protected]>
  • Loading branch information
Electronic-Waste authored Jul 24, 2024
1 parent a8840f2 commit a6c37e4
Showing 1 changed file with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ import (
commonv1beta1 "github.com/kubeflow/katib/pkg/apis/controller/common/v1beta1"
v1beta1 "github.com/kubeflow/katib/pkg/apis/manager/v1beta1"
"github.com/kubeflow/katib/pkg/controller.v1beta1/consts"
"google.golang.org/protobuf/testing/protocmp"
)

func TestCollectObservationLog(t *testing.T) {
Expand Down Expand Up @@ -321,7 +320,8 @@ invalid INFO {metricName: loss, metricValue: 0.3634}`,
if diff := cmp.Diff(test.wantError, err, cmpopts.EquateErrors()); len(diff) != 0 {
t.Errorf("Unexpected error (-want,+got):\n%s", diff)
}
if diff := cmp.Diff(test.expected, actual, protocmp.Transform()); len(diff) != 0 {
observationLogCmpOpts := cmpopts.IgnoreUnexported(v1beta1.ObservationLog{}, v1beta1.MetricLog{}, v1beta1.Metric{})
if diff := cmp.Diff(test.expected, actual, observationLogCmpOpts); len(diff) != 0 {
t.Errorf("Unexpected parsed result (-want,+got):\n%s", diff)
}
})
Expand Down

0 comments on commit a6c37e4

Please sign in to comment.