[GSoC] Added DistributionType to Experiment API
#2377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shashank-iitbhu
commented
Jul 8, 2024
|
// Check that only one of ParameterType or DistributionType is specified
if (param.ParameterType != "" && param.DistributionType != "") ||
(param.ParameterType == "" && param.DistributionType == "") {
allErrs = append(allErrs, field.Invalid(parametersPath.Index(i).Child("parameterType"),
param.ParameterType, "either parameterType or distributionType must be specified, but not both"))
}at katib/pkg/webhook/v1beta1/experiment/validator/validator.go Lines 254 to 256 in 154a85b |
|
/area gsoc |
12 tasks
| DistributionLogUniform Distribution = "logUniform" | ||
| DistributionNormal Distribution = "normal" | ||
| DistributionLogNormal Distribution = "logNormal" | ||
| DistributionCategorical Distribution = "categorical" |
There was a problem hiding this comment.
Yes, removed Categorical from Distribution type.
shashank-iitbhu
force-pushed
the
feat/experiment-api-changes
branch
from
03b2e54
to
00f288e
Compare
Signed-off-by: Shashank Mittal <[email protected]> modified feasibleSpace Removed Categorical from Distribution
shashank-iitbhu
force-pushed
the
feat/experiment-api-changes
branch
from
891879f
to
8a20c60
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
DistributionTypetoParameterSpecinpkg/apis/controller/experiments/v1beta1/experiment_types.go.DistributionType.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #2374
Checklist: