-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update kubeflow/model-registry manifests from v0.2.0-alpha #2697
Update kubeflow/model-registry manifests from v0.2.0-alpha #2697
Conversation
Signed-off-by: Ricardo M. Oliveira <[email protected]>
We should update the model registry synchronization script as I did for Katib in #2698 |
Thanks @rimolive, note that the manifests README and OWNERS files that have been added with kubeflow/model-registry#69 were not included in As temporary solution, if really needed, we could add them manually as part of this PR. Wdyt? |
1be98d8
to
32973e5
Compare
@lampajr Done |
/hold Found an issue in the sync script. |
Signed-off-by: Andrea Lamparelli <[email protected]> Signed-off-by: Ricardo M. Oliveira <[email protected]>
32973e5
to
101fd6d
Compare
/unhold |
networkpolicies etc. in follow up PRs /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: juliusvonkohout, lampajr, rimolive The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…2697) * Update kubeflow/model-registry manifests from v0.2.0-alpha Signed-off-by: Ricardo M. Oliveira <[email protected]> * Setup KF Model Registry GH tests Signed-off-by: Andrea Lamparelli <[email protected]> Signed-off-by: Ricardo M. Oliveira <[email protected]> --------- Signed-off-by: Ricardo M. Oliveira <[email protected]> Signed-off-by: Andrea Lamparelli <[email protected]> Co-authored-by: Andrea Lamparelli <[email protected]>
Which issue is resolved by this Pull Request:
Supersedes #2694
Description of your changes:
Checklist:
Make sure you have installed kustomize == 5.2.1+
make generate-changed-only
make test