Skip to content

Commit

Permalink
fix GHA syntax for dependent env
Browse files Browse the repository at this point in the history
Signed-off-by: Matteo Mortari <[email protected]>
  • Loading branch information
tarilabs committed Mar 18, 2024
1 parent 471563b commit 1235c35
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
3 changes: 2 additions & 1 deletion .github/workflows/build-and-push-image.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ on:
env:
IMG_ORG: kubeflow
IMG_REPO: model-registry
IMG: ${{ env.IMG_ORG }}/${{ env.IMG_REPO }}
DOCKER_USER: ${{ secrets.DOCKERHUB_USERNAME }}
DOCKER_PWD: ${{ secrets.DOCKERHUB_TOKEN }}
PUSH_IMAGE: true
Expand Down Expand Up @@ -51,6 +50,7 @@ jobs:
if: env.BUILD_CONTEXT == 'main'
shell: bash
env:
IMG: ${{ env.IMG_ORG }}/${{ env.IMG_REPO }}
BUILD_IMAGE: false # image is already built in "Build and Push Image" step
run: |
docker tag ${{ env.IMG }}:$VERSION ${{ env.IMG }}:latest
Expand All @@ -60,6 +60,7 @@ jobs:
if: env.BUILD_CONTEXT == 'main'
shell: bash
env:
IMG: ${{ env.IMG_ORG }}/${{ env.IMG_REPO }}
BUILD_IMAGE: false # image is already built in "Build and Push Image" step
run: |
docker tag ${{ env.IMG }}:$VERSION ${{ env.IMG }}:main
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/build-image-pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ on:
env:
IMG_ORG: kubeflow
IMG_REPO: model-registry
IMG: ${{ env.IMG_ORG }}/${{ env.IMG_REPO }}
PUSH_IMAGE: false
BRANCH: ${{ github.base_ref }}
jobs:
Expand All @@ -37,16 +36,17 @@ jobs:
uses: karancode/[email protected]
with:
kustomize_version: '5.2.1'
kustomize_build_dir: 'manifests/kustomize/overlays/db'
- name: Start Kind Cluster
uses: helm/[email protected]
- name: Load Local Registry Test Image
env:
IMG: "${{ env.IMG }}:${{ steps.tags.outputs.tag }}"
IMG: "${{ env.IMG_ORG }}/${{ env.IMG_REPO }}:${{ steps.tags.outputs.tag }}"
run: |
kind load docker-image -n chart-testing ${IMG}
- name: Create Test Registry
env:
IMG: "${{ env.IMG }}:${{ steps.tags.outputs.tag }}"
IMG: "${{ env.IMG_ORG }}/${{ env.IMG_REPO }}:${{ steps.tags.outputs.tag }}"
run: |
echo "Display Kustomize version"
kustomize version
Expand Down

0 comments on commit 1235c35

Please sign in to comment.