Fix disabled text color on DescriptionListDescription (#434)

Signed-off-by: Griffin-Sullivan <[email protected]>
kubeflow · Sep 30, 2024 · 1389f19 · 1389f19
1 parent 0b49bf1
commit 1389f19
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/clients/ui/frontend/src/components/DashboardDescriptionListGroup.tsx b/clients/ui/frontend/src/components/DashboardDescriptionListGroup.tsx
@@ -110,9 +110,10 @@ const DashboardDescriptionListGroup: React.FC<DashboardDescriptionListGroupProps
           </Flex>
         </DescriptionListTerm>
       )}
-      {/* The text color below is a hack for a11y. 
-      PF6 team needs to update their disabled color to work for white backgrounds */}
-      <DescriptionListDescription className={isEmpty && !isEditing ? text.iconColorSubtle : ''}>
+      <DescriptionListDescription
+        className={isEmpty && !isEditing ? text.textColorDisabled : ''}
+        aria-disabled={!!(isEmpty && !isEditing)}
+      >
         {isEditing ? contentWhenEditing : isEmpty ? contentWhenEmpty : children}
       </DescriptionListDescription>
     </DescriptionListGroup>