Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefix for MLMD DB entities of Model Registry #18

Closed
tarilabs opened this issue Feb 22, 2024 · 4 comments · Fixed by #19
Closed

Prefix for MLMD DB entities of Model Registry #18

tarilabs opened this issue Feb 22, 2024 · 4 comments · Fixed by #19
Assignees

Comments

@tarilabs
Copy link
Member

As noted in the Model Registry document: https://github.com/kubeflow/community/pull/682/files#diff-aaf54745ecb36016135c83a5a41a03025574ecb492aec56ef6d2c7c902abfe17R116

we're wrapping MLMD as the underlying stack.

Similarly to KFP, we are storing in the MLMD's DB some domain specific entities: https://github.com/kubeflow/model-registry/blob/main/docs/logical_model.md

We are looking for a "common prefix" nomenclature we should use for these entities, currently these are set to:

  • kfmr.RegisteredModel
  • kfmr.ModelVersion
  • kfmr.ModelArtifact
  • etc.

We're wondering before Alpha release of KF 1.9 we should adopt a more Kubeflow-common prefix such as kf. or kubeflow..

See also slack: https://kubeflow.slack.com/archives/C06JLC34PD0/p1708618535159289

@StefanoFioravanzo
Copy link
Member

+1 for a generic prefix such as kubeflow of kf. If our goal is to build a generic metadata substrate to interconnect all Kubeflow components and potentially interoperate with third-party tools as well, then a kubeflow-wide prefix is preferable.

@tarilabs
Copy link
Member Author

generic metadata substrate to interconnect all Kubeflow components and potentially interoperate with third-party tools as well

Thanks @StefanoFioravanzo for the feedback, all good with a generic prefix if makes our life easier for a standardized way to define namespace/prefixes/... across components!

My only remarks is in quoted part, I would refrain in making interconnection on internal implementation layer (ie have 3rd party tools interoperate at this layer) and rather have components integrate via exposed APIs.

Wdyt?

@StefanoFioravanzo
Copy link
Member

Yes in principle I agree, I didn't mean that third-party software should be able to tap into backend systems. But if metadata structure becomes an open spec that can be consumed and produced by other libraries then we facilitate interoperation. Think of something like MLFlow having a Kubeflow module or extension to produce Kubeflow-compliant artifacts

@tarilabs
Copy link
Member Author

Yes in principle I agree, I didn't mean that third-party software should be able to tap into backend systems. But if metadata structure becomes an open spec that can be consumed and produced by other libraries then we facilitate interoperation.

Yes @StefanoFioravanzo !
We have an (in-progress!) open-spec kind of document, here: https://github.com/kubeflow/model-registry/blob/main/docs/logical_model.md

Think of something like MLFlow having a Kubeflow module or extension to produce Kubeflow-compliant artifacts

Indeed and (at least partially! for the scope of MR) a subject or our gsoc here: https://www.kubeflow.org/events/gsoc-2024/#project-10-enhancing-kf-model-registry-python-client-for-seamless-ml-imports-from-alternative-registries :)

@tarilabs tarilabs self-assigned this Feb 26, 2024
tarilabs added a commit to tarilabs/model-registry that referenced this issue Mar 5, 2024
…stream2

sync upstream KF into midstream ODH
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants